Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove systemd output redirection #6839

Merged
merged 1 commit into from
Jun 17, 2016
Merged

Conversation

jsternberg
Copy link
Contributor

Let systemd handle the output so the journal can be used. This also
let's the user configure if the journal stores the output of this
service to a file instead of setting the location.

Fixes #6824.

@jsternberg jsternberg force-pushed the js-6824-systemd-redirect branch from ab1513b to 5657324 Compare June 14, 2016 17:30
@jsternberg
Copy link
Contributor Author

@rossmcdonald is this a reasonable change so that systemd log files are managed by systemd? It might need to be documented since the log file won't be in the same location as the fallback init script.

@rossmcdonald
Copy link
Contributor

rossmcdonald commented Jun 14, 2016

I believe we'll need to keep the -config /etc/influxdb/influxdb.conf, unless it's being set in the INFLUXD_OPTS environment variable. I have no issues with removing the redirects, though. I never understood why we had the redirects in the first place.

@jsternberg
Copy link
Contributor Author

The configuration file is in a default location that gets read automatically as of 0.13 so the argument isn't needed anymore. It might still be good to put it in though to make it explicit. I'll re-add it.

@jsternberg jsternberg force-pushed the js-6824-systemd-redirect branch from 5657324 to 08818ce Compare June 14, 2016 22:26
@rossmcdonald
Copy link
Contributor

👍 Looks great, thanks!

@jsternberg
Copy link
Contributor Author

@jwilder should this be merged for 1.0 or should this be delayed until 1.1?

@jwilder
Copy link
Contributor

jwilder commented Jun 17, 2016

Does this mean that systems using systemD will no longer have logs in /var/log/influxdb by default now? If so, need to add that to the release notes.

@jsternberg
Copy link
Contributor Author

Yes. If we merge this, systemd will use whatever is the default for the system (typically journald -u influxdb.service).

@jwilder
Copy link
Contributor

jwilder commented Jun 17, 2016

Ok. Please add details to release notes. Otherewise, 👍

Let systemd handle the output so the journal can be used. This also
let's the user configure if the journal stores the output of this
service to a file instead of setting the location.

Fixes #6824.
@jsternberg jsternberg force-pushed the js-6824-systemd-redirect branch from d0d5dd8 to 55a58aa Compare June 17, 2016 18:00
@jsternberg jsternberg merged commit 74cffdb into master Jun 17, 2016
@jsternberg jsternberg deleted the js-6824-systemd-redirect branch June 17, 2016 19:17
@ghost ghost mentioned this pull request Sep 8, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants