-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove systemd output redirection #6839
Conversation
ab1513b
to
5657324
Compare
@rossmcdonald is this a reasonable change so that systemd log files are managed by systemd? It might need to be documented since the log file won't be in the same location as the fallback init script. |
I believe we'll need to keep the |
The configuration file is in a default location that gets read automatically as of 0.13 so the argument isn't needed anymore. It might still be good to put it in though to make it explicit. I'll re-add it. |
5657324
to
08818ce
Compare
👍 Looks great, thanks! |
08818ce
to
d0d5dd8
Compare
@jwilder should this be merged for 1.0 or should this be delayed until 1.1? |
Does this mean that systems using systemD will no longer have logs in |
Yes. If we merge this, systemd will use whatever is the default for the system (typically |
Ok. Please add details to release notes. Otherewise, 👍 |
Let systemd handle the output so the journal can be used. This also let's the user configure if the journal stores the output of this service to a file instead of setting the location. Fixes #6824.
d0d5dd8
to
55a58aa
Compare
Let systemd handle the output so the journal can be used. This also
let's the user configure if the journal stores the output of this
service to a file instead of setting the location.
Fixes #6824.