-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable HTTP service over unix domain socket #7135
Conversation
@oiooj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @gunnaraasen and @e-dard to be potential reviewers |
@@ -101,6 +109,26 @@ func (s *Service) Open() error { | |||
s.ln = listener | |||
} | |||
|
|||
// Open unix socket listener. | |||
if s.unixSocket { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Windows supports unix sockets. Can you check for if the OS is windows and return an error if somebody is trying to use unix sockets on Windows?
412a357
to
1e91770
Compare
@jsternberg updated |
👍 can you update the changelog and give yourself credit? I'll merge on green after that changelog is updated. |
Also remember to rebase your PR onto master. |
1e91770
to
f0c3f4f
Compare
@jsternberg CHANGELOG done. |
Can you rebase on master and put this in the 1.1 section for features? Unfortunately, this isn't going to make it into 1.0 as we closed that off on Monday and we weren't accepting feature requests into it before that. Sorry. |
f0c3f4f
to
6945655
Compare
@jsternberg It's time and I want to go to bed. :P |
Feature Request in #7075 and #4877. Now you can use the http service over TCP and unix domain socket.
config
start
simple client
result