Fixed install/remove of kapacitor on non-systemd Debian/Ubuntu systems #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
martinseener
changed the title
|
Just tell me if it's fine to add it to the CHANGELOG.md to the next version or you could do it yourself. thanks ;) |
|
Don't know why it actually fails :( Update: Ok, doesn't fail anymore. Changed the Distro to 12.04. |
Also added distribution-specific install/remove logic with code copied from telegraf/influxdb scripts. For more rationale, see: influxdata/telegraf#2360
According to last review changes in similar PR on influxdb: influxdata/influxdb#7933
|
Is there a reason, this has not been merged yet? |
3 tasks
|
@martinseener Thanks for the good work here. I have incorporated these changes into #1663. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added distribution-specific install/remove logic with code copied from telegraf/influxdb scripts. For more rationale, see: influxdata/telegraf#2360
Required for all non-trivial PRs