chore: fix two cases where std::result::Result is not fully scoped #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountainpath9
added a commit
to mountainpath9/tkhq-rust-sdk
that referenced
this pull request
Jun 17, 2024
Unfortunately pbjson needs a fix to fully scope some names: influxdata/pbjson#122 This change has Cargo.toml reference a fork with the above change.
|
#128 should fix CI on this crate. Then we can rebase this PR and get it ready to go |
alamb
changed the title
alamb
force-pushed
the
mpath-fix-result-scoping
branch
from
f3732d5
to
5eb56a5
Compare
|
I rebased this PR and reworded the commit message to get it to pass the semanic checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids compilation errors where the source proto files declare a
Resulttype.