fix: Remove as conversions in protocol/primitives.rs
#118
Conversation
| let len = u64::try_from(self.0.len()).map_err(WriteError::Overflow)?; | ||
| UnsignedVarint(len).write(writer)?; |
There was a problem hiding this comment.
Just a small note because we had a chat about integer sizes yesterday:
.len() is usually usize which on 64bit systems is the same as u64. So this is a no-op on 64bit systems (basically all desktops, laptops, servers and about all smartphones nowadays). For 32bit systems (embedded) this also wouldn't be an issue because we would convert to a wider integer. It would only be an issue if usize is 128bit (the only system I know that would allow that is the RISC-V 128bit architecture and there are no chips or compilers available for it) AND when we have more than 2^64 - 1 elements in that list (which would also be insane). So I think this is somewhat of an impossible error case, but on the other hand it also doesn't hurt since the method in question already returns a Result.
Part of #101.