Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: SOCKS5 in CI and docker compose files #135

Merged
merged 2 commits into from
May 23, 2022
Merged

test: SOCKS5 in CI and docker compose files #135

merged 2 commits into from
May 23, 2022

Conversation

crepererum
Copy link
Collaborator

Closes #110.

@crepererum crepererum force-pushed the crepererum/socks5_tests branch 3 times, most recently from 4bf119f to e4078bc Compare May 12, 2022 09:21
@crepererum @mario-s
test: SOCKS5 in CI and docker compose files
5a2cb27 
Closes #110.

Co-authored-by: Mario-S <spindizzy@outlook.com>
@crepererum crepererum marked this pull request as ready for review May 12, 2022 09:35
@crepererum crepererum mentioned this pull request May 12, 2022
Closed
mario-s
mario-s approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@mario-s mario-s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Then I will just close my PR, once this one is merged.

@crepererum crepererum added the automerge Instruct kodiak to merge the PR label May 16, 2022
alamb
alamb approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but I don't really know this code all that well. @tustvold can you take a look too ?

@kodiakhq kodiakhq bot merged commit 6510b23 into main May 23, 2022
@kodiakhq kodiakhq bot deleted the crepererum/socks5_tests branch May 23, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mario-s mario-s mario-s approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
automerge Instruct kodiak to merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable SOCKS5 integration test
3 participants
@crepererum @alamb @mario-s