Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record key/value can be NULL #93

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

crepererum
Copy link
Collaborator

In the NULL case (which can be produced by rdkafka) the length of these
fields is set to -1.

In the NULL case (which can be produced by rdkafka) the length of these
fields is set to -1.
@crepererum crepererum force-pushed the crepererum/fix_nullable_key_value branch from 4a56350 to bc666ee Compare February 3, 2022 10:13
Copy link

@lukebond lukebond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll take your word for it :)

@crepererum crepererum added the automerge Instruct kodiak to merge the PR label Feb 3, 2022
@kodiakhq kodiakhq bot merged commit 1de7759 into main Feb 3, 2022
@crepererum crepererum deleted the crepererum/fix_nullable_key_value branch February 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Instruct kodiak to merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants