Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP plugin incorrectly parses shared memory remotes #3162

Closed
jawi opened this issue Aug 24, 2017 · 2 comments
Closed

NTP plugin incorrectly parses shared memory remotes #3162

jawi opened this issue Aug 24, 2017 · 2 comments
Labels
bug unexpected problem or unintended behavior
Milestone
1.4.0

Comments

@jawi
Copy link
Contributor

jawi commented Aug 24, 2017

Bug report

Relevant telegraf.conf:

[[inputs.ntpq]]
   dns_lookup = false

System info:

  • Telegraf >= 1.3.5;
  • Linux (version not relevant);
  • latest NTPsec.

Steps to reproduce:

  1. use NTPsec instead of NTP as time daemon;
  2. use the shared memory driver to use a local GPS+PPS reference;
  3. observe that the output of ntpq is using aliases like SHM(0) & SHM(1) for the GPS/PPS remotes.

Expected behaviour:

The measurements of both the SHM(0) and SHM(1) remotes to appear in Influx for my host.

Actual behaviour:

Only the measurements of a (non-existing) remote SHM appears for my host.

Additional info:

The issue was introduced with the fix for #2386.

The output of ntpq:

     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
*SHM(1)          .PPS.            0 l    8   16  377    0.000    0.001   0.000
xSHM(0)          .GPS.            0 l    2    2  377    0.000  -116.97   1.414
jawi pushed a commit to jawi/telegraf that referenced this issue Aug 24, 2017
Fixed influxdata#3162 fix parsing of SHM remotes
54ffb4f 
- added test cases for SHM remotes;
- slightly changed the fix for influxdata#2386 to improve and fix the parsing of
  SHM remotes.
@jawi
Copy link
Contributor Author

jawi commented Aug 24, 2017

Created a PR (#3163) that fixes this issue.

@danielnelson danielnelson added this to the 1.4.0 milestone Aug 24, 2017
@danielnelson danielnelson added the bug unexpected problem or unintended behavior label Aug 24, 2017
jawi pushed a commit to jawi/telegraf that referenced this issue Aug 25, 2017
Reverted accidental test code removal
cb85a77 
Due to the changes of influxdata#3162.
@danielnelson
Copy link
Contributor

Thanks @jawi, this will be in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@jawi @danielnelson