Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerospike plugin sometimes failing with panic. #4127

Closed
TheSAS opened this issue May 9, 2018 · 0 comments
Closed

Aerospike plugin sometimes failing with panic. #4127

TheSAS opened this issue May 9, 2018 · 0 comments
Labels
bug unexpected problem or unintended behavior panic issue that results in panics from Telegraf
Milestone

Comments

@TheSAS
Copy link
Contributor

TheSAS commented May 9, 2018

Relevant telegraf.conf:

[agent]
flush_interval = "10s"
flush_jitter = "5s"
hostname = "aerospike-1"
interval = "10s"
round_interval = true
[inputs.aerospike]

System info:

Telegraf v1.6.0 (git: release-1.6 9253f6f)
Amazon Linux AMI release 2017.09

Steps to reproduce:

  1. Just configure aerospike plugin with provided config

Expected behavior:

Work seamlessly.

Actual behavior:

Failing once in a week with:

panic: close of closed channel

goroutine 4 [running]:
github.com/aerospike/aerospike-client-go.(*Cluster).Close(0xc42035f0e0)
        /home/ubuntu/telegraf-build/src/github.com/aerospike/aerospike-client-go/cluster.go:744 +0x4f
github.com/aerospike/aerospike-client-go.(*Client).Close(0xc4203de6f0)
        /home/ubuntu/telegraf-build/src/github.com/aerospike/aerospike-client-go/client.go:108 +0x2e
github.com/aerospike/aerospike-client-go.clientFinalizer(0xc4203de6f0)
        /home/ubuntu/telegraf-build/src/github.com/aerospike/aerospike-client-go/client.go:53 +0x2b

Additional info:

This problem is already fixed in upstream aerospike-client-go by PR: aerospike/aerospike-client-go#208
To fix this problem:

TheSAS added a commit to TheSAS/telegraf that referenced this issue May 9, 2018
@danielnelson danielnelson added this to the 1.6.3 milestone May 9, 2018
@danielnelson danielnelson added the bug unexpected problem or unintended behavior label May 9, 2018
@danielnelson danielnelson added the panic issue that results in panics from Telegraf label May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior panic issue that results in panics from Telegraf
Projects
None yet
Development

No branches or pull requests

2 participants