Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datadog Plugin Spikes CPU #4699

Closed
smicha opened this issue Sep 15, 2018 · 3 comments
Closed

Datadog Plugin Spikes CPU #4699

smicha opened this issue Sep 15, 2018 · 3 comments
Labels
performance problems with decreased performance or enhancements that improve performance
Milestone
1.9.0

Comments

@smicha
Copy link

smicha commented Sep 15, 2018

When I enabled the datadog plugin the cpus on our servers (windows ec2 ) went up from 6% to 35% . Is this normal or am I missing something . I am running a binary that I built with the below command

GOOS=windows GOARCH=amd64 make telegraf and Installed it .
@danielnelson
Copy link
Contributor

@smicha I see that this plugin does a few operations that are somewhat expensive, in particular it calls Metric.Fields() and Metric.Tags() instead of FieldList() and TagList(). We should update the output to use the more efficient methods.

@danielnelson danielnelson added the performance problems with decreased performance or enhancements that improve performance label Sep 17, 2018
@smicha
Copy link
Author

smicha commented Sep 19, 2018

Thanks . I will submit a PR for it tomorrow

kevinconaway pushed a commit to kevinconaway/telegraf that referenced this issue Oct 3, 2018
influxdata#4699 Improve how the datadog plugin uses Metric.Fields and…
6bc77b6 
… Metric.Tags
@kevinconaway kevinconaway mentioned this issue Oct 3, 2018
Merged
kevinconaway pushed a commit to kevinconaway/telegraf that referenced this issue Oct 4, 2018
influxdata#4699 Change buildTags to use Metric.TagsList()
6c4ef29
@danielnelson danielnelson added this to the 1.9.0 milestone Oct 5, 2018
@danielnelson
Copy link
Contributor

Closed in #4803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance problems with decreased performance or enhancements that improve performance
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@danielnelson @smicha