Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensors.go: Incorrect usage of SplitN #748

Closed
ghost opened this issue Feb 23, 2016 · 0 comments
Closed

sensors.go: Incorrect usage of SplitN #748

ghost opened this issue Feb 23, 2016 · 0 comments
Labels
bug unexpected problem or unintended behavior

Comments

@ghost
Copy link

ghost commented Feb 23, 2016

It seems that order of parameters in SplitN function is incorrect:

https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sensors/sensors.go#L52

It should be: parts := strings.SplitN(sensor, ":", 2)
@sparrc sparrc added the bug unexpected problem or unintended behavior label Feb 24, 2016
sparrc added a commit that referenced this issue Feb 26, 2016
@sparrc
Fix sensor plugin, was splitting on ":" incorrectly
19139f3 
closes #748
@sparrc sparrc closed this as completed in 6284e20 Feb 26, 2016
geodimm pushed a commit to miketonks/telegraf that referenced this issue Mar 10, 2016
@sparrc @geodimm
Fix sensor plugin, was splitting on ":" incorrectly
69f796c 
closes influxdata#748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sparrc