-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.nginx_plus_api): Gather limit_reqs metrics #10874
feat(inputs.nginx_plus_api): Gather limit_reqs metrics #10874
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the quick response @glennlod!
!retry-failed |
Required for all PRs:
This was an issue we encountered ourselves thus we didn't create an issue but fixed it immediately. The limit reqs information is very important for NGINX as we need to be able to monitor the amount of requests that were dropped due to those limits.
Description:
Added a new API call to this plugin to gather the limit_reqs metrics that NGINX already exposes.