Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.nginx_plus_api): Gather limit_reqs metrics #10874

Merged

Conversation

glennlod
Copy link
Contributor

@glennlod glennlod commented Mar 23, 2022

Required for all PRs:

This was an issue we encountered ourselves thus we didn't create an issue but fixed it immediately. The limit reqs information is very important for NGINX as we need to be able to monitor the amount of requests that were dropped due to those limits.

Description:
Added a new API call to this plugin to gather the limit_reqs metrics that NGINX already exposes.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 23, 2022
@telegraf-tiger
Copy link
Contributor

@Hipska Hipska added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Mar 23, 2022
@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 29, 2022
@srebhan srebhan self-assigned this Jul 6, 2022
@glennlod glennlod requested a review from reimda July 7, 2022 07:19
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick response @glennlod!

@srebhan
Copy link
Member

srebhan commented Jul 7, 2022

!retry-failed

@reimda reimda merged commit c91eacd into influxdata:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants