Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add license checking tool #11398

Merged
merged 27 commits into from
Jul 28, 2022
Merged

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jun 28, 2022

This PR adds a small tool to verify the license information in docs/LICENSE_OF_DEPENDENCIES.md against the repository content of the individual dependencies.

To run the tool first build it with make build_tools and then

./tools/license_checker/license_checker -whitelist ./tools/license_checker/data/whitelist -cache .licenses.cache .

This will use the whitelisting for github.com/eclipse/paho.mqtt.golang and caches the classification results.

@srebhan srebhan requested a review from sspaink June 28, 2022 12:16
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 28, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefly looked through this, this needs a README on how to run it and details on the whitelist documented.

Other than the items in the whitelist, have you run into many mistakes or issues with trying to parse the licenses? I see the threshold setting and was wondering if you had to play with it to get this to work consistently?

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
tools/license_checker/cache.go Outdated Show resolved Hide resolved
@srebhan
Copy link
Member Author

srebhan commented Jul 27, 2022

@MyaLongmire and @sspaink removed the cache as discussed and added to nightly build. Please have a look and let me know what you think!

.circleci/config.yml Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this!

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@sspaink sspaink merged commit fd84042 into influxdata:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants