-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add license checking tool #11398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Briefly looked through this, this needs a README on how to run it and details on the whitelist documented.
Other than the items in the whitelist, have you run into many mistakes or issues with trying to parse the licenses? I see the threshold setting and was wondering if you had to play with it to get this to work consistently?
…changed in between last tag and master.
@MyaLongmire and @sspaink removed the cache as discussed and added to nightly build. Please have a look and let me know what you think! |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!
This PR adds a small tool to verify the license information in
docs/LICENSE_OF_DEPENDENCIES.md
against the repository content of the individual dependencies.To run the tool first build it with
make build_tools
and then./tools/license_checker/license_checker -whitelist ./tools/license_checker/data/whitelist -cache .licenses.cache .
This will use the whitelisting for
github.com/eclipse/paho.mqtt.golang
and caches the classification results.