Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outputs.groundwork): Improve metric parsing to extend output #11443

Merged
merged 2 commits into from
Jul 20, 2022
Merged

feat(outputs.groundwork): Improve metric parsing to extend output #11443

merged 2 commits into from
Jul 20, 2022

Conversation

ymkins
Copy link
Contributor

@ymkins ymkins commented Jul 1, 2022 •
edited
Loading

Required for all PRs:

resolves #11530

feat/groundwork-output: allow message to be a field, not just a tag
cbc75a2 
Extend the groundwork output plugin to recognize the "message" data
when it comes in as a field rather than only when it comes in as a tag.
This is necessary to process syslog data, inasmuch as the syslog input
plugin generates a "message" field containing the syslog message.
@ymkins ymkins changed the title feat/groundwork-output: allow message to be a field, not just a tag Allow message to be a field, not just a tag Jul 1, 2022
@ymkins ymkins changed the title Allow message to be a field, not just a tag Process message field and tag Jul 1, 2022
@ymkins ymkins changed the title Process message field and tag feat(groundwork-output): Process message field and tag Jul 1, 2022
@ymkins ymkins changed the title feat(groundwork-output): Process message field and tag feat(output.groundwork): Process message field and tag Jul 1, 2022
@ymkins ymkins changed the title feat(output.groundwork): Process message field and tag feat(outputs.groundwork): Process message field and tag Jul 1, 2022
@ymkins ymkins force-pushed the feat/groundwork-output branch 3 times, most recently from 36f9e1c to 04536a8 Compare July 4, 2022 14:45
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 4, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -2.52 % for linux amd64 (new size: 142.4 MB, nightly size 146.1 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj
Copy link
Contributor

powersj commented Jul 7, 2022

Hi,

I hate to sound like a broken record, but can you please file a bug when you make a change to explain why this needs to happen? The change looks fine and I realize you are letting a message be a tag over a field, but it would be good for users of Telegraf to understand what error or reason prompted the change.

@Hipska Hipska added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jul 7, 2022
@ymkins ymkins force-pushed the feat/groundwork-output branch from ff72d34 to a119a0a Compare July 20, 2022 12:01
@ymkins ymkins changed the title feat(outputs.groundwork): Process message field and tag feat(outputs.groundwork): Improve metric parsing to extend output Jul 20, 2022
powersj
powersj approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 20, 2022
@MyaLongmire MyaLongmire merged commit 678e6e7 into influxdata:master Jul 20, 2022
@Hipska Hipska deleted the feat/groundwork-output branch August 1, 2022 08:27
@sjwang90 sjwang90 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire approved these changes

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

outputs.groundwork: adding properties for metric
4 participants
@ymkins @powersj @MyaLongmire @Hipska