Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Error out on requests with no fields defined. #11469

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 7, 2022

Currently, the modbus request-based configuration accepts request sections with no fields defined. This setup does not make any sense, as subsequently no data is requested, and indicates a configuration error. To fail early and loudly, this PR will issue an error for these setups.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 7, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 7, 2022

@srebhan srebhan merged commit 6c7b3b3 into influxdata:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants