Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added "allow_reauth" config option for openstack client #11572

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

singamSrikar
Copy link
Contributor

@singamSrikar singamSrikar commented Aug 1, 2022

Required for all PRs

resolves #

This solves the issue of "unauthorised access" because of Openstack API access token expiration.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 1, 2022
@singamSrikar
Copy link
Contributor Author

@powersj Hey, please review this PR.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @singamSrikar! I wonder if the current behavior is really wanted or if this is simply a bug that should be fixed!?

plugins/inputs/openstack/README.md Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Aug 1, 2022
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Aug 1, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 2, 2022

@singamSrikar
Copy link
Contributor Author

@srebhan updated the code with suggestions, please review. Thanks.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 2, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick response @singamSrikar!

@srebhan srebhan merged commit a049738 into influxdata:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants