Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a conntrack input plugin #1164

Closed
wants to merge 3 commits into from

Conversation

robinpercy
Copy link

  • Collects conntrack stats from the configured directories and files.

@sparrc
Copy link
Contributor

sparrc commented May 18, 2016

some revisions needed:

  • rebase
  • limit line length to 80 chars
  • update README and CHANGELOG
  • provide some documentation or link to documentation on what conntrack is in readme
  • add a dummy windows build file that doesn't do anything (see ntpq plugin for example)

@robinpercy-xm robinpercy-xm force-pushed the pr/input-conntrack branch 2 times, most recently from d505750 to 786ccc9 Compare May 21, 2016 22:53
@robinpercy-xm
Copy link
Contributor

Revisions have been made. I've restricted the build to linux, rather than excluding windows.

- Collects conntrack stats from the configured directories and files.
- Rebased onto master
- Updated README/CHANGELOG
- Limited lines to 80 chars
- Improved plugin docs and README
- added a dummy notlinux build file
@sparrc sparrc closed this in 0fb2d2f May 31, 2016
@sparrc
Copy link
Contributor

sparrc commented May 31, 2016

I'll merge and fix it, but @robinpercy please make sure that in the future you don't change permissions on any existing files in the repo.

your PR includes changing etc/telegraf.conf to mode 755, which is executable and not suitable for a configuration file (did you accidentally do a chmod +x on that file?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants