Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Show file names and line numbers for found issues in github action logs #12618

Merged
merged 2 commits into from
Feb 7, 2023
Merged

chore: Show file names and line numbers for found issues in github action logs #12618

merged 2 commits into from
Feb 7, 2023

Conversation

zak-pawel
Copy link
Collaborator

Right now there file names and line numbers are not shown in github action logs:
image

This PR implements workaround provided here golangci/golangci-lint-action#119 (comment)

@telegraf-tiger telegraf-tiger bot added the chore label Feb 3, 2023
@powersj
Copy link
Contributor

powersj commented Feb 3, 2023

metric.go:35:13 interfacebloat the interface has more than 10 methods: 24

nice! this will be very helpful, thank you!

@zak-pawel
Copy link
Collaborator Author

Thanks to simulated error we can see that workaround works:
image

I will revert error and change can be merged.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 3, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 3, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan merged commit 0339432 into influxdata:master Feb 7, 2023
powersj pushed a commit that referenced this pull request Feb 13, 2023
@zak-pawel @powersj
chore: Show file names and line numbers for found issues in github ac…
006f926 
…tion logs (#12618)

Co-authored-by: Pawel Zak <Pawel Zak>
(cherry picked from commit 0339432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zak-pawel @powersj @srebhan