-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new input plugin type: Webhook #1287
Conversation
b33292f
to
572fa8e
Compare
IMO the webhook plugin should just be a standard service input plugin. That way the current and future webhook plugins will just need to be defined within the "webhook" service input plugin. This allows the webhooks plugin to not be an integral part of the telegraf agent, and also still allows for defining webhook services on multiple ports. ie, config could look something like: [[inputs.webhooks]]
address = ":1925"
[inputs.webhooks.github]
path = "/github"
[inputs.webhooks.rollbar]
path = "/rollbar"
[[inputs.webhooks]]
address = ":1920"
[inputs.webhooks.foobar]
path = "/" Apologies for misunderstanding your proposal earlier |
Ahah, It was my original thought too. Let's do it. |
Required for all PRs:
As proposed in #1248, we moved service plugins which listen independently for webhooks into a new plugin type Webhook. This allow us to register each of these plugin under the same http listener.
What do you think?