Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inputs.minecraft): Migrate plugin to new maintained version of rcon #14868

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

iBug
Copy link
Contributor

@iBug iBug commented Feb 20, 2024

Summary

This is a follow-up to #14756. The original internal/rcon module was vendored from github.com/chuckpreslar/rcon as can be seen in #2960.

Surprisingly the new Rcon library selected in #14756 is very niche: *rcon.Conn satisfies the Connection interface in this package, so the migration is as simple as it seems.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14756

@telegraf-tiger telegraf-tiger bot added chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 20, 2024
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @iBug! Thank you very much!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 21, 2024
@powersj powersj merged commit 4111cee into influxdata:master Feb 21, 2024
25 of 26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 21, 2024
@iBug iBug deleted the update-minecraft branch February 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants