-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix linter findings for revive:enforce-slice-style
in plugins/parsers
, plugins/processors
, plugins/secretstores
and plugins/serializers
#15980
Conversation
…ns/parsers`, `plugins/processors`, `plugins/secretstores` and `plugins/serializers`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I wonder if you can leave out all the make([]xyz, 0)
statements in the tests to simplify the code!?
…ice-style_parsers_processors_secretstores_serializers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more instances that can be removed IMO...
…ice-style_parsers_processors_secretstores_serializers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last suggestion @zak-pawel! ;-)
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @zak-pawel!
…ns/parsers`, `plugins/processors`, `plugins/secretstores` and `plugins/serializers` (influxdata#15980)
Summary
Address findings for revive:enforce-slice-style in
plugins/parsers
,plugins/processors
,plugins/secretstores
andplugins/serializers
.As we agreed here #15812, we will fix the errors found by the following configuration:
It is only part of the bigger job.
After all findings of this type in whole project are handled, we can enable
revive:enforce-slice-style
rule ingolangci-lint
.Checklist