feat(inputs.ipset): Add metric for number of entries and individual IPs #16124
+226
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
verybadsoldier
force-pushed
the
feat/input/ipset_entries
branch
from
368af7d
to
28500db
Compare
…r of individual IPs
verybadsoldier
force-pushed
the
feat/input/ipset_entries
branch
from
28500db
to
c562e98
Compare
srebhan
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Thanks @verybadsoldier for your contribution. I do have some comments in the code...
verybadsoldier
force-pushed
the
feat/input/ipset_entries
branch
from
3b048ee
to
60e0d89
Compare
|
Thanks for the review comments! |
|
Should I resolve the conversation I think I have solved or is that up to you? |
srebhan
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Thanks for the update @verybadsoldier! A few more comments...
srebhan
changed the title
srebhan
changed the title
srebhan
changed the title
verybadsoldier
force-pushed
the
feat/input/ipset_entries
branch
from
e534444
to
7bb1170
Compare
* rename misnamed "initialized" parameter * remove "reset" function * remove "initSet" function * return err from addLine instead of adding to acc * rework switch block in addLine
verybadsoldier
force-pushed
the
feat/input/ipset_entries
branch
from
7bb1170
to
44a78df
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
|
Thanks for bearing with me, I think I addressed all your latest comments now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some automatic blacklist systems (like e.g. FireHOL) are feeding known malicious IP addresses regularly into ipsets to be blocked by firewalls (e.g. iptables/nftables). It would be useful to be able to track the number of entries of such ipsets over time.
As entries can use CIDR notation to target a range of IPs (e.g. 10.12.4.0/8) with a single ipset entry, it is also useful to see the number of actualy IPs affected by one ipset.
Checklist
Related issues
resolves #16103