-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common.socket): Use read buffer size config setting as a datagram reader buffer size. #16156
fix(common.socket): Use read buffer size config setting as a datagram reader buffer size. #16156
Conversation
… reader buffer size.
…ize as the only possible buffer size value for UDP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarekZydor thanks for your contribution! Please fix the unit-test so we can get this merged.
If SetWriteBuffer execution fails then skip test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarekZydor for the update. Two small comments then we are good to go I think...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarekZydor!
Summary
Currently, the datagram read buffer size is fixed at 64 KB, which is leading
to data loss when receiving large datagrams (metrics) over Unix Domain Sockets (unixgram).
This fix ensures that the buffer size matches read-buffer-size
configuration, preventing truncation of incoming data.
Checklist
Related issues
resolves #16118