fix(inputs.gnmi): Register connection statistics before creating client #16171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/gnmi
feat
srebhan
reviewed
Nov 11, 2024
plugins/inputs/gnmi/gnmi.go
Outdated
Comment on lines
281
to
282
| address: addr, | ||
| host: host, |
There was a problem hiding this comment.
Do we need the address in the handler then?
There was a problem hiding this comment.
No if I add port also to handler, is that better? To drop address and add host + port, as client, err := grpc.NewClient(h.address, opts...) still needs host + port
There was a problem hiding this comment.
dropped address and added port to handler and joining address from it, before connecting
srebhan
changed the title
srebhan
removed
the
feat
Mrflatt
force-pushed
the
gnmi-connection-status
branch
4 times, most recently
from
4e23111
to
bd0f82a
Compare
Now selfstat does not report status of connection if setup of subscription fails. This makes harder to check all hosts statuses, when host count per telegraf is high.
Mrflatt
force-pushed
the
gnmi-connection-status
branch
from
bd0f82a
to
6fd28c1
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Nov 12, 2024
srebhan
added
the
ready for final review
DStrand1
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now gnmi selfstat does not report status of connection if setup of subscription fails. This makes harder to check all hosts statuses, when they are missing from selfstat. We are using internal plugin to see failures on grpc status, and some host are missing cause subscription fails and self stat is never reported.
Also changed selfstat source to be same as in other metrics, don't know if this is ok to do :)
Checklist
Related issues