More mysql metrics #165
Closed
More mysql metrics #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome, thanks for your contribution @nickscript0! two things before I can merge:
thanks much! |
|
I did sign the CLA previously so should be on the list (let me know if I need to sign again) and CHANGELOG.md is updated with this change now. |
|
you're right, I didn't see your name because our internal list hasn't been sorted 😅, I'll merge this, thanks again! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional MySQL metrics to the mysql plugin. These additional measurements can be filtered out using the pass/drop filters in case there is a concern around storing more data.
I updated mysql_test.go with the new mappings and "make test" passes for me.