Fix MySQL plugin not sending 0 value fields #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @caldwell, update the changelog and I can merge |
discosysadmin
force-pushed
the
fix-mysql-zero-values
branch
from
7bfdaaa to
b8b4dc0
Compare
|
I amended the patch to update the changelog. |
jackzampolin
pushed a commit
that referenced
this pull request
Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that certain mysql booleans were only being written to our influxdb and cloudwatch outputs when they were true. This makes graphing difficult in grafana and alarms impossible in cloudwatch.
Looking at the code in
parseValue(): In the case of"Yes"or"ON"the function returnsvalue=1, ok=true, and in the case of"No"or"OFF"it returnsvalue=0, ok=false. Whenokisfalse, telegraf drops the field and doesn't report it. This appears to be a simple bug (which has been there since theparseValue()code was first committed).This PR changes
oktotruefor false values so that they get written to the metrics outputs instead of dropped.Required for all PRs: