Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device name as a tag in disk stats #1807

Merged

Conversation

mediocretes
Copy link
Contributor

@mediocretes mediocretes commented Sep 23, 2016

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

This returns device name as a tag (alongside mount point), and removes /dev/ from the device name for ease of reading.

… report device name (minus /dev/) as a tag in disk stats
@phemmer
Copy link
Contributor

phemmer commented Sep 24, 2016

You might want to look at #1453. Currently it only affects diskio inputs. But it should be easy to include it on the disk inputs as well.

@mediocretes
Copy link
Contributor Author

@sparrc Any guidance?

If this isn't going to make it, we need to think about how our backend is going to handle mount points without sending some really odd data.

@sparrc
Copy link
Contributor

sparrc commented Nov 17, 2016

thanks for reminding, we'll try to get it ready for 1.2

@sparrc sparrc added this to the 1.2.0 milestone Nov 17, 2016
@sparrc sparrc merged commit d518d7d into influxdata:master Dec 5, 2016
@sparrc sparrc mentioned this pull request Jan 26, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants