feat(kubernetes): Add kubernetes input plugin #1847
Conversation
jchauncey
force-pushed
the
kubernetes-plugin
branch
2 times, most recently
from
2375690 to
75bedbf
Compare
sparrc
added
plugin request
feature request
jchauncey
force-pushed
the
kubernetes-plugin
branch
from
75bedbf to
8caed26
Compare
There was a problem hiding this comment.
@jchauncey thanks for the PR!
A couple requests:
- example yaml file for configuring telegraf to run as daemon set
- example output / line protocol
| "namespace": pod.PodRef.Namespace, | ||
| "name": container.Name, | ||
| "pod": pod.PodRef.Name, | ||
| "uid": pod.PodRef.UID, |
There was a problem hiding this comment.
Will this and the other uid tags have very high or unlimited cardinality?
There was a problem hiding this comment.
yes. everytime a pod dies and comes back it would have a new uuid. Same thing with pod name
jchauncey
force-pushed
the
kubernetes-plugin
branch
2 times, most recently
from
bfa0203 to
1b1bf56
Compare
| "namespace": pod.PodRef.Namespace, | ||
| "name": container.Name, | ||
| "pod": pod.PodRef.Name, | ||
| "uid": pod.PodRef.UID, |
There was a problem hiding this comment.
yes. everytime a pod dies and comes back it would have a new uuid. Same thing with pod name
jchauncey
force-pushed
the
kubernetes-plugin
branch
from
1b1bf56 to
0c30800
Compare
|
@jchauncey I'm concerned this plugin will generate stats with very high cardinality, it appears that you are storing a UUID as a tag for every:
In a typical kubernetes setup, how frequently would you expect new UUIDs of each of these to get generated? how frequently in a high-volume kubernetes setup? |
|
It largely depends. We could remove the uuid but we will still have high cardinality with the pod name because it has a unique identifier which changes every time the pod dies. Im guess over a month there may be a few hundred pod uuids created on a moderately sized cluster. |
|
I can tell you we churn around 3-5k pods a day. I would like to see options to limit the amount of churn for specific pods. |
|
What I could do is have a flag that allows you to exclude pod name from the On Oct 14, 2016 6:19 PM, "Shane Starcher" notifications@github.com wrote:
|
|
@jchauncey AFAICT simply excluding the pod name & uuid will only lead to duplicate metrics overwriting each other. If flags are added they will need to completely disable to per-pod and per-container metrics from being gathered. Does kubernetes not provide any sort of aggregated metrics? From what I can see in this PR the metrics are all very high cardinality. |
|
No that's the point of this plugin is to get detailed pod metrics. On Oct 14, 2016 6:58 PM, "Cameron Sparr" notifications@github.com wrote:
|
jchauncey
force-pushed
the
kubernetes-plugin
branch
from
0c30800 to
be9a046
Compare
jchauncey
force-pushed
the
kubernetes-plugin
branch
from
be9a046 to
79dfca7
Compare
jchauncey
force-pushed
the
kubernetes-plugin
branch
from
79dfca7 to
a12bd87
Compare
There was a problem hiding this comment.
👍 lgtm - @jchauncey thank you for contributing this plugin and all the quick code review updates!
|
Yeay!! This is a great plugin!!! 👍 |
Required for all PRs:
closes #1774