-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the tags in the graylog output plugin #1861
Conversation
@vanillahsu can you review this please? @edieship I'm not very familiar with graylog, but are there users who might not want tags in their graylog metrics? What sort of query capability does this add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems ok to me.
are there any drawbacks to adding the tags? @jamescarr can you review as well? |
The reason I want to add the tags is because almost all the metrics come with different tags to better differentiate them. For example, for the docker container metrics, the container name is one tag, without the tags in the metric output, it'a very difficult to tell which container are the metrics for. |
@edieship, it makes sense, TBH I'm surprised that the metrics were useful at all without the tags. I just want to make sure that current users of the plugin won't get negatively affected by this. |
Yeah this is useful because I also hit this problem. The tags are useful for filtering in graylog (for example, I commonly want to look at logs for a particular zone). |
OK, @edieship you can update the changelog and I'll merge |
cherry-picked the commits and made some tweaks to avoid some unnecessary allocations in the hash map: #1865 |
Required for all PRs:
This is just to include the metric tags as well in the graylog output plugin, at the moment only metric values are included.