Add trailing slash to jolokia context #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
instead of modifying the input the user provides, why not just make the |
|
@sparrc That makes sense. I'll update the |
stevenpall
force-pushed
the
jolokia-context
branch
4 times, most recently
from
b882bdd to
0d3487d
Compare
sparrc
suggested changes
Dec 16, 2016
| @@ -6,6 +6,7 @@ | |||
| # Read JMX metrics through Jolokia | |||
| [[inputs.jolokia]] | |||
| ## This is the context root used to compose the jolokia url | |||
| ## NOTE that Jolokia requires a trailing slash at the end of the context root | |||
| context = "/jolokia" | |||
There was a problem hiding this comment.
add the trailing slash here as well
stevenpall
force-pushed
the
jolokia-context
branch
from
0d3487d to
01d035f
Compare
sparrc
approved these changes
Dec 17, 2016
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
If one is using the suggested Jolokia plugin configuration, the following will cause the plugin to fail:
The server requires a trailing slash (i.e.
http://127.0.0.1:8778/jolokia/). This change adds a slash to the end of the context parameter if it is not present.