Add field for last GC pause time #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevjef
force-pushed
the
feature/field-for-gc-pauses
branch
from
0d74afa to
a8b0265
Compare
sparrc
reviewed
Dec 3, 2016
| @@ -202,6 +203,7 @@ func (i *InfluxDB) gatherURL( | |||
| "next_gc": m.NextGC, | |||
| "last_gc": m.LastGC, | |||
| "pause_total_ns": m.PauseTotalNs, | |||
| "pause_ns": m.PauseNs[(m.NumGC+255)%256], | |||
There was a problem hiding this comment.
what if NumGC == 0? Should the index be 255?
There was a problem hiding this comment.
The index doesn't matter when NumGC == 0 since every element in PauseNs[0:256] will be zero.
|
@sparrc Any reason why this wouldn't make the 1.2.0 release? |
|
None in particular, just a large backlog :), I'll try to get it in since it's a rather small change |
tevjef
force-pushed
the
feature/field-for-gc-pauses
branch
from
a8b0265 to
df5a04e
Compare
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: