-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change jolokia input to use bulk requests #2253
Conversation
This is huge, thanks! |
looks good, please rebase and remove the changelog update for now, as this will be going into 1.3 |
Done |
looking fwd then to v1.3 release (any ETA?) ! ps:
I guess this is no real issue, as any such syntactic errors would be detected on the first request, and assuming the reported error/exception message contains enough information about what mbean/string contains the error. |
@phemmer Just to make sure, this is still a useful update even though we are planning to merge the new jolokia2 plugin this cycle? If so, can you add back to changelog. |
Does "jolokia2" do bulk requests? |
According to the PR it does, though I haven't looked at the code. Let's add it to the changelog then. |
Yes, |
It's not breaking because it is a new plugin, right? |
Changelog updated. |
Required for all PRs:
This adjusts the jolokia input to use bulk requests. This significantly increases the performance of it.
In my specific use case, I have a deployment where it takes ~10.4 seconds to gather all the requested jolokia metrics. With this change it now takes ~0.04 seconds (260x faster).
There is one behavioral change as a result of this PR. If the configuration has a syntatically invalid mbean name, instead of just failing to gather that one metric, all metrics will fail. This is because if jolokia can't parse the request, it fails the entire request. Missing mbeans/attributes still behave the way they previously have, in that an error for that specific metric will be logged, but all others will be gathered.
You can find details on this here: jolokia/jolokia#124
Closes #1328