Wavefront output plugin #2288
Wavefront output plugin #2288
Conversation
First cut of wavefront storage driver - quotes tag values
- Added convert_groups config parameter - Cleaned up error messages - Removed all references to OpenTSDB format
- Updated configuration names and default values - Updated special character handling and added new regex option - Added new “hidden” DebugAll option to print original metric and field names
- Change tag host to be source per Wavefront data format - Added SimpleFields property which when true will use “value” as field name when specified (default false) - Cleanup of sample config
Full support for Wavefront data format
# Conflicts: # Makefile # plugins/outputs/wavefront/wavefront.go # plugins/outputs/wavefront/wavefront_test.go
# Conflicts: # Makefile # plugins/outputs/wavefront/wavefront.go # plugins/outputs/wavefront/wavefront_test.go
- Use new logging form or D! or E! - added tagValueReplacer just for tag values, instead of using santizedChars - re-added forward slash (/) to sanitizedChars
- Changed order of variables to match sample config and readme
- point tag names with quotes `”` will now be escaped `\”`
- removed redundant (and commented) statsd section
|
+1 for getting this plugin merged. |
|
Can we get an update on status on this PR, will it be a candidate for the next release? I made a few small changes to resolve all outstanding conflicts. |
|
@puckpuck I don't have this scheduled for the next release at this time. |
|
@danielnelson Any reason why not to include it? Are you waiting for go plugins in 1.8? |
|
It has more to do with the prioritization of issues and pull requests. |
|
@puckpuck Can you add a silent mode for the wavefront plugin? Because wavefront only accepts numeric values, any plugin that sends a mixture of numeric values and non-numeric values ends up blowing up the log |
danielnelson
added
feat
|
Trying to get an understanding on what we need to do in order to get this PR included into 1.4? Would closing it and resubmitting as a single commit help? |
|
@danielnelson and @nhaugo I created a Wavefront trial account a while ago but it was never activated. I can resend the link to the email we have. As for rebasing, I tried, and I believe I may have entered git hell :(. My original fork was based on another fork which has since diverged away from a full fork, and rebase from upstream keeps giving me errors that I need to merge, but merge is also not working o_O. Another option is I throw away my current repo, and start anew with a fork from influxdata/telegraf instead, but that would require a new PR. |
|
Rebasing might be easier if you just squash your branch into one commit, especially since there is very little overlapping code. You can also force push a new branch so long as you use the same branch name on your remote. |
|
@danielnelson I've tried, and get a bunch of merge conflicts, even on files I never touched. It's not difficult for me to trash the repo and fork again, re-add my changes and submit a new PR |
|
ok |
Required for all PRs:
This is a new output plugin for Wavefront. Wavefront is a SaaS for metrics. You can learn more about Wavefront on their website: https://www.wavefront.com
We have been using this output plugin for multiple months with a few Wavefront customers yielding great results, and are ready to release it to the community so it can be part of the main telegraf package.