-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -config-directory argument to Windows service #2312
Conversation
you need to run |
Sorry about that. Fixed. |
It looks like scripts/build.py doesn't create the Is that something we should worry about here, or should it be left up to users installing the service on Windows? |
can you modify build.py to make that directory? |
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build.py update
Ah, no, that doesn't set a default. |
I added a bit of documentation around using the configuration directory in Windows as a service. a9afd2f I don't think we should set a default value across the board, but if we add an installer in the future it could help setup a location and directory for this. |
Fixes #1797
Telegraf will fail to start if given a
-config-directory
that doesn't exist. The arguments used by the service won't change unless Telegraf is run with-service install
and-service uninstall
, so breakage as a result of this change seems unlikely.Required for all PRs:
README.md updated (if adding a new plugin)