Fix telegraf swallowing panics in --test mode #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@butitsnotme can you review this? In #1543 you said that this defer was necessary because otherwise telegraf wouldn't exit properly. I haven't been able to reproduce that and I can't seem to figure out why it wouldn't exit correctly in the first place. Do you have any thoughts on that? is it Windows-specific? |
|
nevermind, scratch that, I can reproduce. I'll have to figure out a solution for this... |
sparrc
changed the title
sparrc
force-pushed
the
cs2341
branch
2 times, most recently
from
2c7d3fe to
3da1731
Compare
this defer function was causing telegraf to call os.Exit(0) instead of panicking when it was supposed to. closes #2341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
closes #2341