Fix ipmi_sensor config is shared between all plugin instances #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
force-pushed
the
fix-multiple-ipmi-sensors
branch
from
e651e8a to
f5500d1
Compare
phemmer
reviewed
Apr 19, 2017
plugins/inputs/ipmi_sensor/ipmi.go
Outdated
| path, _ := exec.LookPath("ipmitool") | ||
| if len(path) > 0 { | ||
| m.Path = path | ||
| } |
There was a problem hiding this comment.
Not that exec.LookPath is expensive, and worth the effort to keep from repeating it, but you could do something like:
inputs.Add("ipmi_sensor", func() telegraf.Input {
m := m
return &m
})
vlamug
pushed a commit
to vlamug/telegraf
that referenced
this pull request
May 30, 2017
3 tasks
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed ipmi_sensor always returns the same struct instance. This prevents having separate ipmi_sensor plugins active with different configs.
Required for all PRs: