Add wildcard inclusion/exclusion support to container names #2793
Conversation
|
If the changes look okay, I will go ahead implementing the tests. |
|
What are the possible states other than running? |
|
@danielnelson, I guess the possible states are: paused, restarting, removing, running, dead, created, exited. I suppose it only makes sense to track containers in running state? I'd see no reason to extend this to containers in states other than running? |
m4ce
changed the title
|
@danielnelson - let me know if the changes look good. Once they do, I will take care of the test units. |
m4ce
force-pushed
the
2737
branch
4 times, most recently
from
0b7b36e to
88151a8
Compare
m4ce
changed the title
plugins/inputs/docker/README.md
Outdated
| ## Only collect metrics for these containers, collect all if empty | ||
| container_names = [] | ||
|
|
||
| ## Containers to include and exclude. Globs accepted. | ||
| ## Note that the options are ignored when using the container_names option. An empty array for both will include all containers |
There was a problem hiding this comment.
We should favor the new options, maybe you can just append container_names to the new value? Then document that the old version is deprecated. Include the version it is deprecated in and the replacement, something like: "Deprecated (1.4.0), use container_name_include"
m4ce
force-pushed
the
2737
branch
4 times, most recently
from
11cdd08 to
47a1fec
Compare
|
@danielnelson - I've made the changes. If they look good, I will proceed with the test cases. |
|
Looks good |
m4ce
force-pushed
the
2737
branch
2 times, most recently
from
1ef8081 to
573d7e7
Compare
|
@danielnelson - I've added the tests. It's ready to merge. |
|
Perfect! |
This PR solves #2734 .