fix monitoring not working with rethinkdb 2.3.5 #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue - #2958 |
|
Thanks for the PR, looks good overall, but I think this will break compatibility with rethink < 2.3. Could you change the password/username to have their own config settings and then if authkey is set also do this? https://github.com/GoRethink/gorethink/blob/master/CHANGELOG.md#changed-10 |
|
Can you change the pull request to go into master? |
3 tasks
|
Please, ignore this PR - i made another one to master branch with fixes - #2963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: