Feature/jolokia plugin #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiello
force-pushed
the
feature/jolokia-plugin
branch
from
2470bc0 to
33b02cc
Compare
saiello
force-pushed
the
feature/jolokia-plugin
branch
from
33b02cc to
abbdc3f
Compare
Closed
|
@saiello can you please write a README for this plugin? you can use the CPU readme as an example: https://github.com/influxdb/telegraf/blob/master/plugins/system/CPU_README.md |
|
@saiello, I'm not super familiar with JMX/jolokia/MBeans, but it seems like this information is more generically called an |
| return ` | ||
| context = "/jolokia/read" | ||
|
|
||
| [jolokia.tags] |
There was a problem hiding this comment.
this should be space-indented
|
@saiello nevermind about renaming the plugin, I get it now, |
|
Once you write a README and address my comments I'll merge it, thanks a bunch @saiello! |
|
@sparrc I added a README to jolokia plugin. I hope to have fixed the indentation as well 😁 Thanks |
|
thank you @saiello! |
allenj
pushed a commit
to allenj/telegraf
that referenced
this pull request
Nov 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a simple JVM plugin based on jolokia rest api.
I needed to add some new methods in testutil/accumulator.go hence I refactor the oldest to use them.