Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SSL settings to ElasticSearch output plugin #3406

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Add support for SSL settings to ElasticSearch output plugin #3406

merged 1 commit into from
Oct 30, 2017

Conversation

adityacs
Copy link
Contributor

@adityacs adityacs commented Oct 30, 2017 •
edited by danielnelson
Loading

Closes #3129

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@adityacs adityacs force-pushed the elasticsearchoutput branch from 7594c61 to 42130fb Compare October 30, 2017 17:54
danielnelson
danielnelson reviewed Oct 30, 2017
View reviewed changes
plugins/outputs/elasticsearch/elasticsearch.go Outdated
)

type Elasticsearch struct {
URLs []string `toml:"urls"`
Scheme string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused, I think this is cruft from development.

plugins/outputs/elasticsearch/elasticsearch.go Outdated
return err
}
tr := &http.Transport{
ResponseHeaderTimeout: a.Timeout.Duration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the header timeout, I think we usually don't usually need this but it keeps getting copied around from other plugins...

@danielnelson danielnelson added this to the 1.5.0 milestone Oct 30, 2017
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 30, 2017
@adityacs adityacs force-pushed the elasticsearchoutput branch from 42130fb to 2a92503 Compare October 30, 2017 19:50
@adityacs
Copy link
Contributor Author

@danielnelson Have made the changes. Thanks for the review.

@danielnelson danielnelson merged commit 23ad959 into influxdata:master Oct 30, 2017
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@adityacs @danielnelson
Add support for SSL settings to ElasticSearch output plugin (#3406)
78df21d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnelson danielnelson danielnelson left review comments

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adityacs @danielnelson