add HTTP basic auth support to the http_listener input plugin #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielnelson any chance this could land in a release sometime soon? I’d love to get our build process off of my fork. |
danielnelson
added
area/influxdb
feat
|
I will try to review for 1.6. |
|
Looks good but can you remove the HTTPS test code, I don't think it is necessary to test that for this code. |
3 tasks
add basic auth config to default telegraf.conf removed https tests
3van
force-pushed
the
http-listener-auth
branch
from
01de075 to
9a31a30
Compare
|
Ugh, sorry, I totally forgot about this (until someone reminded me that our builds were still happening from my fork, haha). HTTPS tests removed now! |
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Does what it says on the tin. Needed it for a specific use case, and saw no reason for it to not be there, so here we are.