Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL plugin should not collect global variables at each telegraf data collection interval #3500

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

lgosselin
Copy link
Contributor

When you set interval_slow (to a positive value), MySQL plugin starts gathering the global variables.

What is expected (in accordance with the README.md): The gathering of variables occurs at a slower pace than the regular telegraf data collection interval. And the pace would be the value interval_slow (+ an eventual jitter of 1 telegraf interval).

What is actually happening: The plugin collects the global variable at every single data collection interval.

The fix is not to call the gathering when it was done less than interval_slow duration ago.

Note:

  • I've signed the CLA
  • I did not change the README.md. This pull request is to make the code behave as advertised in the README.md.
  • I don't know how to produce a unit test that validates the timing. I've checked by looking at the timestamps in influxdb.

@lgosselin lgosselin changed the title MySQL plugin should not collect global variables at each telegraf data collection interation MySQL plugin should not collect global variables at each telegraf data collection interval Nov 24, 2017
@danielnelson danielnelson added this to the 1.4.5 milestone Nov 27, 2017
@danielnelson danielnelson added the fix pr to fix corresponding bug label Nov 27, 2017
@danielnelson danielnelson merged commit f758d0c into influxdata:master Nov 27, 2017
@danielnelson
Copy link
Contributor

Thank you!

danielnelson pushed a commit that referenced this pull request Nov 27, 2017
aromeyer pushed a commit to aromeyer/telegraf that referenced this pull request May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants