Add new SSL input plugin #3829
Add new SSL input plugin #3829
Conversation
|
@mgrabazey Can you take a look at this similar pull request and let me know if it would fulfill your use? #3768 |
|
@danielnelson This implementation does not check whether the certificate matches the domain on which the certificate is used |
| } | ||
| defer ipConn.Close() | ||
|
|
||
| tlsConn := tls.Client(ipConn, &tls.Config{ServerName: d, InsecureSkipVerify: true}) |
There was a problem hiding this comment.
If we're going to set InsecureSkipVerify: true, we should probably do a manual verification step and indicate the status. It's possible for an intermediate or root cert to be revoked (or expired in the case of a stupid CA), which would invalidate the cert.
|
@mgrabazey We did merge the alternate plugin for certificate checking, and I think we should be able to integrate the certificate verification pieces into that plugin. I opened a feature request for this addition #4877. |
Required for all PRs:
A new simple plug-in for checking the time to expiration of the ssl certificate and its correspondence to the domain