GOPATH can have multiple : separated paths in it. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, forgot to mention: the reason that I personally run into this is that I sometimes need to run with from the godep docs, as some parts of my IDE are not as smart as they should be yet. This will also come up for people who use multiple paths to separate personal code from internet code. |
gotyaoi
changed the title
|
@gotyaoi We could also just require that GOBIN is part of the users PATH to use the makefile. That way we could just remove all of the GOBIN references and simply execute |
|
Possibly. Another possibility would be to add all possible GOBIN directories to the front of the PATH in the makefile. I'll try that out tonight. |
This means that simply adding /bin to the end is not enough. Instead of setting GOBIN, this version prepends things to the PATH. If GOBIN is already set, simply prepends GOBIN to PATH. If not, appends /bin to each component of GOPATH, then prepends that to PATH.
|
@sparrc How does that look? |
|
looks good, thanks @gotyaoi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't find an easy way to do this in make language. Pretty sure this is sh compatible.