Fix minmax and basicstats aggregators to use all number types #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #4293 |
|
Fields types can now (since 1.6) only be int64, uint64, float64, string, and bool [1]. Let's just add support for uint64 so we don't need to use the reflect package. There are a variety of unittests that use other units, but the unittests just need to be fixed. [1]: https://github.com/influxdata/telegraf/blob/master/metric/metric.go#L251 |
These aggregators were not working with number type uint64 Telegraf uses externals libs that uses this type
danielnelson
pushed a commit
that referenced
this pull request
Jun 30, 2018
(cherry picked from commit 85eacf2)
codesmith14
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Jul 5, 2018
(cherry picked from commit 85eacf2)
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aggregators were not working with other numbers type not being
float64 or int64.
Telegraf uses externals libs that could use other types.
Required for all PRs: