#4624 Add the ability to specify a custom datadog URL #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
suggested changes
Oct 3, 2018
plugins/outputs/datadog/datadog.go
Outdated
| func (d *Datadog) Connect() error { | ||
| if d.Apikey == "" { | ||
| return fmt.Errorf("apikey is a required field for datadog output") | ||
| } | ||
|
|
||
| if d.URL == "" { | ||
| d.URL = datadog_api |
There was a problem hiding this comment.
Set this in the init() function and then it will be overridden automatically when the plugin in loaded.
plugins/outputs/datadog/datadog.go
Outdated
| client *http.Client | ||
| } | ||
|
|
||
| var sampleConfig = ` | ||
| ## Datadog API key | ||
| apikey = "my-secret-key" # required. | ||
|
|
||
| # The base endpoint URL can optionally be specified but it defaults to: | ||
| url = "https://app.datadoghq.com/api/v1/series" |
There was a problem hiding this comment.
Comment this line out since it won't usually need to be set:
## The base endpoint URL can optionally be specified but it defaults to:
# url = "https://app.datadoghq.com/api/v1/series"
There was a problem hiding this comment.
Suggested change
| url = "https://app.datadoghq.com/api/v1/series" | |
| url = "https://app.datadoghq.com/api/v1/series" |
If the user is using an open source datadog-agent, this will be very useful to specify the url if they don't want to send the metrics to datadoghq.
For example:
/var/lib/dcos/telegraf/telegraf.d
[centos@x.x.x.x telegraf.d]$ cat datadog.conf
# Transmit all metrics to Datadog
[[outputs.datadog]]
## Datadog API key
apikey = "redacted"
## Connection timeout
# timeout = "5s"
## URL
url = "http://custom_url:443/api/v1/metrics"```
danielnelson
added
the
feat
kevinconaway
force-pushed
the
issue-4624
branch
from
981fdf0 to
b987934
Compare
|
@danielnelson I've incorporated your feedback, thanks for your time! |
glinton
approved these changes
Oct 4, 2018
danielnelson
approved these changes
Oct 5, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4624
Required for all PRs:
The existing tests covered this behavior