-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : size options can come with units (KB, MiB, ...) #4852
Merged
danielnelson
merged 12 commits into
influxdata:master
from
Samuel-BF:feature/size-with-units
Oct 19, 2018
Merged
Feature : size options can come with units (KB, MiB, ...) #4852
danielnelson
merged 12 commits into
influxdata:master
from
Samuel-BF:feature/size-with-units
Oct 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8,000 bytes (and not 536,870,912bytes, which are 512 MiB)
Samuel-BF
changed the title
Feature/size with units
Feature : size options can come with units (KB, MiB, ...)
Oct 12, 2018
glinton
added
the
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
label
Oct 12, 2018
Looks good, just need to resolve the conflicts caused when we aliased |
@danielnelson : done. |
glinton
approved these changes
Oct 19, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Some options can now be expressed either as int (without quotes, representing the value in Bytes), either as strings with units ("100KiB", "-5MB" ...). These options are :
I've not modified max_message_bytes from outputs/kafka because 1. the parallel option in kafka is also expressed in bytes without units and 2. it would be necessary to rename the option.
The default configuration is also updated to show examples with units.
How it works
It adds the internal.Size type, which can be used by plugins. The configuration option is processed by (*Size) UnmarshalTOML function, which uses units package.
Required for all PRs: