Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config field for Stackdriver output resource_type #5389

Conversation

Legogris
Copy link
Contributor

@Legogris Legogris commented Feb 7, 2019

This makes resource type configurable for Stackdriver output. Different resource types have different limits on Google's side.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@Legogris Legogris force-pushed the stackdriver-output-config-resourcetype branch from 81aa1a3 to 9fa18f3 Compare February 7, 2019 14:54
@Legogris
Copy link
Contributor Author

Legogris commented Feb 7, 2019

Support for setting resource labels addressed separately in #5391. Should this PR be closed in favor of that one or better to treat the separately?

@danielnelson danielnelson added this to the 1.10.0 milestone Feb 8, 2019
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 8, 2019
@danielnelson
Copy link
Contributor

Let's just merge #5391, since you really need both features.

@danielnelson danielnelson removed this from the 1.10.0 milestone Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants