-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix basedir check and parent dir extraction in filecount input #5630
Conversation
(cherry picked from commit 5f74c0d)
This does not work for me on windows, was the fix tested on windows, or just linux please ? tested with: [[inputs.filecount]] |
telegraf.exe V1.11.0 |
@SimonMcN Most likely I only tested on Linux, I'll reopen the issue and try it out when I have a Windows system available. |
I'd appreciate it. I know the Linux and windows filesystems have different mount point syntax so it would be easy to break it by mistake..... Either that or I am incapable 🤔😐😋 |
Looks to be related to the path separators, I believe using backslashes will workaround this issue until the fix is released. You can either escape the backslashes directories = ['E:\mydirectory\processed\Failed'] |
Fix for the separator issue is here: #6077 |
Not just a Windows bug, previously we would panic on paths without a
/
, and it was possible to not detect the top directory if it was aliased with a different path.closes #5621
Required for all PRs: