Gh webhooks #573
Gh webhooks #573
Conversation
| return ` | ||
| # Address and port to host Webhook listener on | ||
| service_address = ":1618" | ||
| # Measurement name |
There was a problem hiding this comment.
these should be 2-space indentation
|
Looks good! Just some comments to address that should get the build working again as well. Few other things:
|
|
@sparrc For sure! |
|
@sparrc 👀 |
| github.com/hailocab/go-hostpool 50839ee41f32bfca8d03a183031aa634b2dc1c64 | ||
| github.com/hashicorp/go-msgpack fa3f63826f7c23912c15263591e65d54d080b458 | ||
| github.com/hashicorp/raft b95f335efee1992886864389183ebda0c0a5d0f6 | ||
| github.com/hashicorp/raft-boltdb d1e82c1ec3f15ee991f7cc7ffd5b67ff6f5bbaee | ||
| github.com/influxdata/influxdb 0e0f85a0c1fd1788ae4f9145531b02c539cfa5b5 | ||
| github.com/influxdb/influxdb 0e0f85a0c1fd1788ae4f9145531b02c539cfa5b5 | ||
| github.com/influxdb/influxdb c1d6c14c47dfb4d60878a979fbdd8b526281d3d6 | ||
| github.com/influxdb/telegraf d3a5cca1bc18f315dacbd9941f1e4556fde86538 |
There was a problem hiding this comment.
Not sure what happened here, but it shouldn't list itself as a dependency. What does your project source directory look like? is it not $GOPATH/src/github.com/influxdata/telegraf?
There was a problem hiding this comment.
Its got an internal dependancy. I separated out some stuff into another package. Should I move it all into one package?
There was a problem hiding this comment.
what do you mean by internal dependency? I just mean that the telegraf repo shouldn't need to import itself (as an external dependency) in any situation. The Godeps file is for external dependencies only.
|
@sparrc 👀 |
First go at a telegraf plugin. It listens for events pushed out Github and persists relevant data from them to configured outputs.
@sparrc